0000157: the source about DLListBase::link is logically wrong - OpenFOAM® Bugs Reporting - Mantis

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0000157

OpenFOAM

[All Projects] Bug

public

2011-03-06 14:13

2012-01-11 16:29

Reporter

tdchenhao

Assigned To

l_r_mcglashan

Priority

high

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Linux

OS

ubuntu

OS Version

10.04

Product Version

1.7.x

Target Version

Fixed in Version

2.1.x

Summary

0000157: the source about DLListBase::link is logically wrong

Description

The member function bool DLListBase::swapUp(DLListBase::link* a) is not correct!
In link, the next pointer of end member is defined pointing to its self. So the line below is wrong !
file :/src/OpenFOAM/containers/LinkedLists/linkTypes/DLListBase/DLListBase.C
line 106: a->next_->prev_ = ap;
line 117: ap->next_ = a->next_;

I think the auther must copy this code from other files in which the the next pointer of end member of a list is defined pointing to NULL!

Steps To Reproduce

Watch the source code!

Additional Information

Please fix it hurry!

Tags

No tags attached.

DLListBase.C [^] (5,133 bytes) 2011-03-06 14:13

Relationships

Notes
(0000281) henry (manager) 2011-03-09 13:22	Do you have a small test code which shows a problem? The test application OpenFOAM-1.7.x/applications/test/DLList runs correctly.

(0000916) l_r_mcglashan (developer) 2012-01-11 16:29	Thanks for the report. swapUp and swapDown in DLList assigned an incorrect pointer to the first and last elements respectively. This has been fixed. Resolved by commit 988050d36a43d4ba541b0b1c7ce218eedf7451d6

Issue History
Date Modified	Username	Field	Change
2011-03-06 14:13	tdchenhao	New Issue
2011-03-06 14:13	tdchenhao	File Added: DLListBase.C
2011-03-09 13:22	henry	Note Added: 0000281
2012-01-11 16:29	l_r_mcglashan	Note Added: 0000916
2012-01-11 16:29	l_r_mcglashan	Status	new => resolved
2012-01-11 16:29	l_r_mcglashan	Fixed in Version	=> 2.1.x
2012-01-11 16:29	l_r_mcglashan	Resolution	open => fixed
2012-01-11 16:29	l_r_mcglashan	Assigned To	=> l_r_mcglashan