View Issue Details

IDProjectCategoryView StatusLast Update
0002078OpenFOAMPatchpublic2016-05-01 09:13
Reporterwyldckat Assigned Tohenry  
PrioritylowSeveritytextReproducibilityN/A
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0002078: A few more description fixes for "src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields"
DescriptionAttached is the package "turb_comp_turb_deriv.tar.gz", which provides the following fixes for the files present in the aforementioned folder (full path included inside the package):

 - externalCoupledTemperatureMixed/externalCoupledTemperatureMixedFvPatchScalarField.H

    - Updated description to the current rendering done by Doxygen, namely using \verbatim in several situations.


 - externalWallHeatFluxTemperature/externalWallHeatFluxTemperatureFvPatchScalarField.H

    - Minor space adjustment.


 - thermalBaffle1D/thermalBaffle1DFvPatchScalarField.H

    - Changed "Class" to be in the correct "Foam::compressible::" namespace


 - turbulentHeatFluxTemperature/turbulentHeatFluxTemperatureFvPatchScalarField.H

    - Changed "Class" to be in the correct "Foam::compressible::" namespace


 - turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.H

    - Rearranged first paragraph a little;
    - and added typo fix that was reported at develop.openfoam.com #101.


 - turbulentTemperatureRadCoupledMixed/turbulentTemperatureRadCoupledMixedFvPatchScalarField.H

    - Added typo fixes that were reported at develop.openfoam.com #101;
    - And made the description consistent with the sibling classes that derive from temperatureCoupledBase.
TagsNo tags attached.

Activities

wyldckat

2016-04-30 21:00

updater  

wyldckat

2016-04-30 21:03

updater   ~0006211

I forgot to mention that I've followed the latest instructions from here: http://openfoam.github.io/Documentation-dev/html/codingStyleGuide.html

Although there are some situations where it's very hard to follow the guidelines, for example in the file "turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.H", the verbatim with the patch usage block can't be indented an additional +4 spaces, otherwise it goes over the limit of 80 columns in a single line.

henry

2016-05-01 09:13

manager   ~0006217

Thanks Bruno
Resovled by commit f8588e31f8cca63fb7fcfce8b0dcb9f010e1f775

Issue History

Date Modified Username Field Change
2016-04-30 21:00 wyldckat New Issue
2016-04-30 21:00 wyldckat Status new => assigned
2016-04-30 21:00 wyldckat Assigned To => henry
2016-04-30 21:00 wyldckat File Added: turb_comp_turb_deriv.tar.gz
2016-04-30 21:03 wyldckat Note Added: 0006211
2016-05-01 09:13 henry Note Added: 0006217
2016-05-01 09:13 henry Status assigned => resolved
2016-05-01 09:13 henry Fixed in Version => dev
2016-05-01 09:13 henry Resolution open => fixed