View Issue Details

IDProjectCategoryView StatusLast Update
0004045OpenFOAMBugpublic2024-01-09 10:10
Reportertniemi Assigned Tohenry  
PrioritylowSeverityminorReproducibilitysometimes
Status resolvedResolutionfixed 
Product Versiondev 
Fixed in Versiondev 
Summary0004045: Uninitialised finalIter_ in solutionControl.C
DescriptionFollowing this commit
https://github.com/OpenFOAM/OpenFOAM-dev/commit/836ce9a30253ba93efa899b08c6e0af4b630b0ea

it seems that cases with Poisson walldist or hydrostaticInitialisation (and transient ddt) no longer work unless Final-solver setting is specified. The following tutorials don't work due to lacking yPsiFinal or ph_rghFinal solver settings:

tutorials/multiRegion/film/rivuletBox
tutorials/multiphaseEuler/bubblePipe
tutorials/multicomponentFluid/smallPoolFire2D
tutorials/multicomponentFluid/smallPoolFire3D

It seems that the finalIter_-member is not initialised in the constructor of solutionControl.C so it might have a random non-zero value defaulting to true and hence requiring "Final". This affects any equation that is solved before the main loop starts. The pimple-loop will reset the finalIter_ and work correctly afterwards.

The issue can be fixed by simply adding finalIter_(false) to the initializer list of solutionControl.C to restore the earlier behaviour.

TagsNo tags attached.

Activities

henry

2024-01-09 10:10

manager   ~0013181

Resolved by commit 53ddbda670cdbeeae3607615d12922d961ef495d

Issue History

Date Modified Username Field Change
2024-01-09 06:49 tniemi New Issue
2024-01-09 10:10 henry Assigned To => henry
2024-01-09 10:10 henry Status new => resolved
2024-01-09 10:10 henry Resolution open => fixed
2024-01-09 10:10 henry Fixed in Version => dev
2024-01-09 10:10 henry Note Added: 0013181