View Issue Details

IDProjectCategoryView StatusLast Update
0004064OpenFOAMBugpublic2024-03-15 15:05
ReporterApanasevich Assigned Towill  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformamd64OSRocky LinuxOS Version8.6
Product Versiondev 
Fixed in Versiondev 
Summary0004064: Module functions: typo in key "subSolver" leads to an endless loop
DescriptionTypo in key "subSolver" (e.g. "subsolver") in controlDict causes an endless loop at the simulation start and the simulation aborts immediately.

A test case with multiphaseFlow and functions is attached: s. the log file
Steps To ReproduceRun the attached test case
TagsNo tags attached.

Activities

Apanasevich

2024-03-15 12:50

reporter  

henry

2024-03-15 13:55

manager   ~0013213

This is due to the need to default to reading the "solver" name in the post-processing context:

    // Read the solverName from the subSolver or solver entry in controlDict
    const word solverName
    (
        runTime.controlDict().found("subSolver")
      ? runTime.controlDict().lookup("subSolver")
      : runTime.controlDict().lookup("solver")
    );

The only way around this would be to check for all the different ways that "subSolver" might be incorrectly spelled by the user.

wyldckat

2024-03-15 14:38

updater   ~0013215

The following is not ideal, but at least it follows most of OpenFOAM's convention of exiting when something essential isn't found:


    if (!runTime.controlDict().found("subSolver") && !runTime.controlDict().found("solver"))
    {
        FatalError...
    }

    // Read the solverName from the subSolver or solver entry in controlDict
    const word solverName
    (
        runTime.controlDict().found("subSolver")
      ? runTime.controlDict().lookup("subSolver")
      : runTime.controlDict().lookup("solver")
    );

will

2024-03-15 15:05

manager   ~0013216

Fixed in dev by https://github.com/OpenFOAM/OpenFOAM-dev/commit/d8df5789203b9e0320bc298879afc35e1a679d26

Issue History

Date Modified Username Field Change
2024-03-15 12:50 Apanasevich New Issue
2024-03-15 12:50 Apanasevich File Added: bubbleColumn_functions_bug.zip
2024-03-15 13:55 henry Note Added: 0013213
2024-03-15 14:38 wyldckat Note Added: 0013215
2024-03-15 15:05 will Assigned To => will
2024-03-15 15:05 will Status new => resolved
2024-03-15 15:05 will Resolution open => fixed
2024-03-15 15:05 will Fixed in Version => dev
2024-03-15 15:05 will Note Added: 0013216